fixes #78 #79
Merged
fixes #78 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var x = underlying.getStart | ||
|
|
||
| while (x < underlying.getEnd) { |
There was a problem hiding this comment.
When using 1 to 3 in Scala, I expect it give me Seq(1, 2, 3), which includes the last value.
Hence I would expect the to here will give me the last value, too.
Would it be better to use while (x <= underlying.getEnd) here?
There was a problem hiding this comment.
You, are right. I have opened a separate issue for this: #83.
There was a problem hiding this comment.
But intervals are more like start until end, instead of start to end.
For interval contains interval.end is false.
And this method will return a collection contains a point which is not in the original interval.
@pishen @wookietreiber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements and rudimentary tests a solution for #78.