Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Smart conversion option ("Smart Transcode") Audio/Video #86

Closed
nschlia opened this issue May 16, 2021 · 5 comments
Closed

[FEATURE] Smart conversion option ("Smart Transcode") Audio/Video #86

nschlia opened this issue May 16, 2021 · 5 comments
Assignees

Comments

@nschlia
Copy link
Owner

nschlia commented May 16, 2021

Add a "Smart Transcode" option

  • Convert audio-only files to WAV or AIFF
  • Convert video-only and audio-video files to MOV

Smart transcoding currently simply determines the output format by taking the input format type into account, e.g., an MP3 would be recoded to AIFF, an MP4 to MOV even if the input MP4 does not contain a video stream.

The input format should be scanned for streams and the output selected appropriately: An MP4 with video should be transcoded to MOV, an MP4 with audio only to AIFF.

@nschlia nschlia self-assigned this May 16, 2021
@nschlia nschlia changed the title [Fature] Smart conversion option ("Smart Transcode") Audio/Video [Feature] Smart conversion option ("Smart Transcode") Audio/Video May 16, 2021
@nschlia nschlia changed the title [Feature] Smart conversion option ("Smart Transcode") Audio/Video [FEATURE] Smart conversion option ("Smart Transcode") Audio/Video Jun 8, 2021
@dreirund
Copy link

dreirund commented Nov 3, 2021

Would this also solve the fact that when --desttype=MP3+WEBM or --desttype=MP3+MP4, all audio files get transcoded to WebM or MP4?

It would be nice if some transcoding-mappings could also be specified manually by from-to-pairs, e.g. --mapping=<mimetype>:<format> (multiple options possible).

@nschlia
Copy link
Owner Author

nschlia commented Nov 3, 2021

Would this also solve the fact that when --desttype=MP3+WEBM or --desttype=MP3+MP4, all audio files get transcoded to WebM or MP4?

This would recode audio formats to MP3 and video files to WebM or MP4. Audio only formats will never be recoded to WebM or MP4 in these cases. BTW, --desttype=MP3+MP4 would not make much sense as MP4 can perfectly contain audio only.

Currently the decision whether to target MP3 or WebM is taken by the capabilities of the input format - e.g. WAV or AIFF gets recoded to MP3. AVI or MP4 to WebM, even if the source does not contain video. This is quite dumb.

The enhancement planned would be that a check is added so that a video capable format that contains no video will be transcoded to MP3.

As now the files are checked first for cue sheets the necessary information should be available soon enough. I*ll see if I can implement the feature now,

It would be nice if some transcoding-mappings could also be specified manually by from-to-pairs, e.g. --mapping=<mimetype>:<format> (multiple options possible)

Probably this could be done, but what would be the use case for this?

@dreirund
Copy link

dreirund commented Nov 3, 2021 via email

@nschlia
Copy link
Owner Author

nschlia commented Nov 6, 2021

Think that should be possible now. The problem was, the input file must be scanned first to detect video tracks. At the time I implemented this feature this was not done. But now the files get scanned for cue sheets and thus I have the information required.

@nschlia nschlia closed this as completed in 8ecc2cf May 9, 2022
@dreirund
Copy link

dreirund commented May 9, 2022

🙂

nschlia added a commit that referenced this issue May 10, 2022
nschlia pushed a commit that referenced this issue May 11, 2022
Write separate logs for both tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants