Support for generating a line loop for a polygonal shape from a list of coordinates

[ghost]

PyGmsh can create a Plane Surface quite easily for a polygonal shape using add_polygon. However, for a polygon with holes you need to create a Plane Surface from a set of Line Loop's. These additions facilitate the generation of the line loops.

[nschloe]

Thanks for the PR!

Some suggestions:

• A bit of code is now duplicated between add_polygon and add_polygon_lineloop & friends. You could just call add_polygon_lineloop from add_polygon. The latter then shrinks down to only adding the plane surface.
• A bunch of methods already have the optional argument holes. Perhaps that would be useful for add_polygon, add_rectangle etc. too.

[ghost]

I was thinking along the exact same line. However, before hacking & slashing all your code I wanted confirmation whether the additions were valuable.

I'll try to extend add_polygon (next week or so) to also have the holes capability and remove add_polygon_loop afterwards.

[nschloe]

No need to remove the add_polygon_loop, we still need it to be used as holes.

[ghost]

Hi @nschloe, I refactored add_polygon to remove the duplicity I created by implementing add_polygon_loop. Also, I added the optional argument holes in add_polygon to facilitate the generation of holes in a polygonal shape.

[nschloe]

Looks good. Can you do the same thing for the rectangle as well?

[ghost]

I'll have a look this week.

[ghost]

Done

[nschloe]

Merged, thanks!