package_bin: Fix callback arg to package path instead of alias name

[zchee]

Fix callback arg to package path.
This fix will resolve that issue.
#352

I don't know whether this pull request is correct. If the wrong fix, please point out.

Also, there might be a problem because I tested only a little.
but _testing/all.bash test is all passed.

• p.callback(parent.path, tdecl)
  • for decl_var.
• p.callback(parent.path, &ast.FuncDecl{
  • for decl_func.

---

Test sample:

package main

import (
    "go/parser"
    "go/token"
    "io/ioutil"
    "log"
)

func main() {
    buf, err := ioutil.ReadFile("hello.go")
    if err != nil {
        log.Fatal(err)
    }

    fset := token.NewFileSet()
    f, err := parser.ParseFile(fset, "hello.go", buf, parser.Mode(0))
    if err != nil {
        log.Fatal(err)
    }

    f.
}

byte offset: 348
cmd: gocode --in ./parser.go autocomplete 348

package main

import "github.com/derekparker/delve/service/rpc2"

const addr = "localhost:41222" // d:4 l:12 v:22

func pointerStruct() {
    client := rpc2.NewClient(addr)
    bp, _ := client.GetBreakpoint(-1)

    bp.
}

byte offset: 210
cmd: gocode --in ./delve.go autocomplete 210

[nsf]

Yeah, I wish I knew. I will take a look at it this weekend for sure, but for now I'll just pull it.

[zchee]

@nsf Thanks!! I learned a lot from that.
Thanks for the great tool.

[nsf]

Well, I took a look at parsed output of both Go 1.6 (text) and Go 1.7 (bin) data. Yeah, seems like your patch fixes it. Ideally I guess I need to make sure that both parsers generate exactly the same output if that's possible. But I'll leave for another time for now. Thanks for the fix.

[zchee]

@nsf Hi,

I took a look at parsed output of both Go 1.6 (text) and Go 1.7 (bin) data. Yeah, seems like your patch fixes it.

Thanks review.
and yes, It seems to could not be parsed package because gc_bin_parser callback is not full path.

Ideally I guess I need to make sure that both parsers generate exactly the same output if that's possible.

Sorry, Is it meaning adding some of the tests? or another meaning?
If the meaning is test, I can write the test.
If other than that, I will implement it. (In both cases, I might not be able to live up to your demands)

[nsf]

Don't worry it's all great, you don't have to do anything.

[zchee]

@nsf understand. Thanks :)