package_bin: Add bimport v1. backport https://golang.org/cl/24648/ #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is response to the change of src/cmd/compile/internal/gc/bimport.go bimport has added v1. See - golang/go@575a871 - golang/tools@6c3528d Signed-off-by: Koichi Shiraishi <k@zchee.io>
|
Hm. One moment, will take a look at the thing. |
|
Thanks for the patch. Edit: It works indeed. |
|
@nsf Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bimport has added v1 variable.
Just as in #305, gocode can not provide complete word or occur
PANICerror ongo version devel +575a871or higher.This is response to the change of src/cmd/compile/internal/gc/bimport.go
See
This change is simply carried code from
golang.org/x/tools/go/gcimporter15/bimport.go.There may be a wasted code. Please review it if you have time.
I was tested
go version devel +519b469 Sat Jul 2 00:40:40 2016 +0000 darwin/amd64and
go version go1.6.2 darwin/amd64.The complete word on IDE(such as vim) works, no
PANICand completion looks perfect.but_testingtests failed.So, this pull-request is WIP. I will investigate why the test fails.Edit: Hmm... I'm re-test
./all.bash, now all tests have passed.Added
strikethroughto the above comment.