You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
nsf
merged 1 commit into
nsf:master
from
ryboe:masterJan 6, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will break compilation on older versions of Go. Although to be honest, I'm not sure if gocode compiles there. So, I'll probably accept the patch, will think about it for a few days. Probably nobody uses Go versions 1.4 and older.
Go is pretty unique among programming languages in that most of the community is using a recent version of the language. Upgrades are pretty smooth because the language doesn't change much. The Go team only officially supports the two most recent major versions (currently 1.8 and 1.9). Older versions do not receive security updates. It's up to you, but I think it's ok to drop support for 1.7 and older.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes gocode pass
go vet ./....