support go1.11 beta2 Go modules #523
Conversation
|
I'm having issues getting completions from different packages in the same module. Tried with and without this patch, and the behavior was roughly the same. |
|
Are you aware that a module-aware loader is being worked on here by the go team? |
|
@joefitzgerald thanks |
There was a problem hiding this comment.
go get -u github.com/nsf/gocode
cd $GOPATH/src/github.com/nsf/gocode
# check out this PR
git config --add remote.origin.fetch '+refs/pull/*/head:refs/remotes/origin/pr/*'
git fetch
git checkout -t origin/pr/523
go install ./
Works well on go version go1.11beta3 darwin/amd64. Thank you!
|
I'll take a look at it closer to Go 1.11 release. Since RC is already out, maybe this weekend. |
|
Just to echo #523 (comment), See also: |
|
Yeah, sorry for not looking it. I guess it's time for me to draw a line here and declare gocode as not maintained. And it kind of was for quite some time. If you need autocompletion for go and gocode doesn't work for you, look for alternatives. I decided not to merge this pull request, because it's pointless since I'm not maintaining the project anymore. Thanks for working on it though, feel free to keep a fork of it. I know it will make a lot of people angry at me, but that's it. I'm done for now with open source projects. I will update a README with a note about this in a sec. |
|
@visualfc can you please submit this PR against https://github.com/mdempsky/gocode? |
|
@VojtechVitek as I mentioned in #523 (comment), the approach here should be to use |
|
See also mdempsky#46 |
|
Referencing the new fork: https://github.com/visualfc/gocode - works well with go1.11. @myitcv |
|
For anyone interested, https://github.com/stamblerre/gocode fork is built on top of golang.org/x/tools/go/packages. Works for me so far and feels much faster. |
|
We really need one fork to incorporate all useful PRs. @nsf do you consider adding other maintainers to this project as this repo is still treated by many other people as the "official" source. |
|
No I'm not interesting in keeping it alive at all. I want something better. Where's my "go language server" with all the fancy features like typescript has for example? Sadly I won't be making one, even though I totally can. Hence I don't see a point in maintaining gocode with patches and hacks. Google has a whole team dedicated to Go, what are they doing? |
|
@cnbuff410 Seems like https://github.com/stamblerre/gocode changes will end up in https://github.com/mdempsky/gocode fork according to mdempsky#46. |
|
@nsf maybe https://github.com/sourcegraph/go-langserver could become the thing you're describing? |
|
Yes, there is such possibility. |
|
Please see the notes from the first three sessions of the golang-tools group https://docs.google.com/document/d/1lB49VLzDrRd3wbXP1uLf-bHQyJRmH_Dc36JeEBlK-1Q/edit https://docs.google.com/document/d/1G7bEKWeFRjd9rPCkBJooC76CCb0Jiem5F_Q48C1zecQ/edit As these notes confirm the Go tools team are working on such a language server. Please join the group for further updates: |
use github.com/visualfc/types to parser package and cached.
support vendor and Go1.11 modules.