Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add truecolor output mode #104

Closed
wants to merge 1 commit into from

Conversation

deathlyfrantic
Copy link

Hi - this PR adds a true color (24-bit) color mode. Colors should be specified as 0xRRGGBB. I don't think this breaks anything in the other output modes - I tested all the demos - but it's possible I missed something. Please let me know if any changes are needed. Thanks!

@nsf
Copy link
Owner

nsf commented May 9, 2017

Sorry, I won't merge it. See reasoning here: #37

I really don't want people using terminals for fancy UIs. To me, even 256 color mode was a mistake. Because if we follow that road, what's next? Different font sizes and images? You know, some terminals can do that...

Join HTML cult.

@amirouche
Copy link

It's seems to me that you prefer that a large part of the community fork termbox.

@@ -288,6 +289,9 @@ SO_IMPORT int tb_select_input_mode(int mode);
* This mode supports the 4th range of the 256 mode only.
* But you dont need to provide an offset.
*
* 5. TB_OUTPUT_TRUECOLOR => [0x000000..0xFFFFFF]
* This mode supports 24-bit true color. Format is 0xRRGGBB.
*
* Execute build/src/demo/output to see its impact on your terminal.
*
* If 'mode' is TB_OUTPUT_CURRENT, it returns the current output mode.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome read ❤️

@nsf
Copy link
Owner

nsf commented May 9, 2017

It's seems to me that you prefer that a large part of the community fork termbox.

That is in fact true. And I pointed it out in the issue I gave a link to. It says I'm in "maintenance only mode". Which means no new features from me and being very hesitant about merging features implemented by other people..

@ddevault
Copy link

ddevault commented May 9, 2017

If you're concerned about the burden of ongoing maintenance, you can give write access to someone else. I would be happy to volunteer, since termbox is a dependency of some of my software. Forking is bad for everyone.

Despite what you may have come to believe, there are a great many use cases for which a TUI is suited. My software is among them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants