Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetComplete synthesizes config for a too strict sketch (6) #23

Closed
alehed opened this issue May 24, 2018 · 3 comments
Closed

NetComplete synthesizes config for a too strict sketch (6) #23

alehed opened this issue May 24, 2018 · 3 comments

Comments

@alehed
Copy link
Collaborator

alehed commented May 24, 2018

In the completely non-symbolic sketch that is set in a way that the path R2, R1, R4, R6 is preferred due to it having a lower IGP metric, NetComplete synthesizes a configuration for the requirement that the path R2, R1, R3, R5 should be preferred.

Steps to reproduce:

  • replace 1 with 6 in the method test_single_fail_configuration of 'test_bgpver.py'
  • run only this test case
  • check that the requirements are not met by running python grigori/checking/network.py var/tmp/
@alehed
Copy link
Collaborator Author

alehed commented May 28, 2018

Right now this still fails.

@alehed alehed reopened this May 28, 2018
@ahassany
Copy link
Member

Hmm, I don't what do you mean by fails.

But the IGP costs are set to symbolic, so net complete will synthesize correct IGP costs.

I printed the edge costs and found the following:

Cost R1->R3 EMPTY?Value
Cost R1->R4 EMPTY?Value

@alehed
Copy link
Collaborator Author

alehed commented May 28, 2018

My bad, that is just a too stupid mistake.

@alehed alehed closed this as completed May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants