Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook to access, download and plot GeoTIFFs using MEaSUREs data sets as examples #52

Merged
merged 57 commits into from
Jun 14, 2023

Conversation

jroebuck932
Copy link
Collaborator

This is the latest version of the measures notebook. It has been generalized so it can be used for data sets that have GeoTIFF format and uses two MEaSUREs data sets as an example. I have not created a rendered version yet, I will do that once I have addressed all comments/suggestions from the review.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@asteiker asteiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent tutorial, @jroebuck932! I just added a few comments and suggestions but nothing major. A few other reminders (which again speaks to the need for a cookie cutter template for new tutorials!):

  • Add an environment.yml to this folder. The checks are failing and I'm guessing this is why.
  • And new heading for this tutorial on top-level ReadMe
  • Add a rendered copy.

notebooks/measures/README.md Outdated Show resolved Hide resolved
notebooks/measures/README.md Show resolved Hide resolved
notebooks/measures/Search_Download_and_Plot_GeoTIFFs.ipynb Outdated Show resolved Hide resolved
notebooks/measures/Search_Download_and_Plot_GeoTIFFs.ipynb Outdated Show resolved Hide resolved
notebooks/measures/Search_Download_and_Plot_GeoTIFFs.ipynb Outdated Show resolved Hide resolved
notebooks/measures/Search_Download_and_Plot_GeoTIFFs.ipynb Outdated Show resolved Hide resolved
notebooks/measures/Search_Download_and_Plot_GeoTIFFs.ipynb Outdated Show resolved Hide resolved
notebooks/measures/Search_Download_and_Plot_GeoTIFFs.ipynb Outdated Show resolved Hide resolved
notebooks/measures/Search_Download_and_Plot_GeoTIFFs.ipynb Outdated Show resolved Hide resolved
@nsidc nsidc deleted a comment from github-actions bot Jun 7, 2023
@nsidc nsidc deleted a comment from github-actions bot Jun 13, 2023
@betolink
Copy link
Member

@asteiker I think this work is complete but there is an issue with the big file in the Snowex notebook, the notebook ran OK when executed manually but with Quarto there is an error about the path, my theory is that the next cell gets executed before the aws command completes copying the file from S3. In any case the rest of the notebooks ran... and also for one of the notebooks there is a YAML bug with Quarto on the output.

@github-actions
Copy link

github-actions bot commented Jun 14, 2023

Binder 👈 Launch a binder notebook on this branch for commit 1b6c196

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit db45a63

Binder 👈 Launch a binder notebook on this branch for commit 1b0092a

Binder 👈 Launch a binder notebook on this branch for commit bec6b0c

Binder 👈 Launch a binder notebook on this branch for commit 17673f4

@asteiker asteiker merged commit 4ccbdee into main Jun 14, 2023
5 checks passed
@asteiker asteiker deleted the measures branch June 14, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants