Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cryo 165 - update ICESat-2 cloud access with search_data method #56

Merged
merged 12 commits into from
Aug 1, 2023
Merged

Cryo 165 - update ICESat-2 cloud access with search_data method #56

merged 12 commits into from
Aug 1, 2023

Conversation

jroebuck932
Copy link
Collaborator

A few minor updates to the ICESat-2 Cloud access notebook:

  • Replace granule_query with search_data method so it is consistent with what will be presented at earthdata webinar.
  • And updated to include version 6 of ATL06 as an example instead of version
  • Updated README to include set up instructions specific to the cloud (based on feedback).

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited

Binder 👈 Launch a binder notebook on this branch for commit 1415c01

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit ac4ef36

@asteiker asteiker self-assigned this Jul 24, 2023
@asteiker asteiker self-requested a review July 24, 2023 18:38
asteiker
asteiker reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@asteiker asteiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates are great. I left a few minor comments using ReviewNB.

betolink
betolink approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@betolink betolink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great @jroebuck932 ! I liked the note on ignoring the [None] values.

@asteiker asteiker merged commit d53ee91 into main Aug 1, 2023
5 checks passed
@asteiker asteiker deleted the cryo-165 branch September 5, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypbarrett andypbarrett andypbarrett left review comments

@asteiker asteiker asteiker left review comments

@betolink betolink betolink approved these changes

Assignees

@asteiker asteiker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jroebuck932 @betolink @andypbarrett @asteiker