Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of all Root regions file example and file examples for list of subdivisions and metadata for each root region. #24

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

sebastien-lenard
Copy link
Collaborator

First test of generation for List of all Root regions file example (root_regions.json) and file examples for list of subdivisions and metadata for each root region westernUS and WCanada ( regions_26000.json and regions_26101.json, respectively).

…ubdivisions and metadata for each root region.

First test of generation for List of all Root regions file example (root_regions.json) and file examples for list of subdivisions and metadata for each root region westernUS and WCanada ( regions_26000.json and regions_26101.json, respectively
"subdivisionListAndMetadataRelativePath": "subdivisionlist/subdivisionlist_26000.json"
},
"26002": {
"name": "ASHimalayas",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "AS" stand for here? For the "name" field that we're going to show to users, let's spell it out!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AS is for Asia, AM for America. I propose to let Karl be in charge of deciding the final names, to avoid spending time on it (even if very small time)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that proposal :) 🚀

@MattF-NSIDC MattF-NSIDC merged commit 98706d6 into main Oct 10, 2023
2 checks passed
@MattF-NSIDC MattF-NSIDC deleted the sl-json-backend-generation-tests branch October 10, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants