Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit message Update variables.json with new ids #53

Merged
merged 11 commits into from
Feb 20, 2024

Conversation

sebastien-lenard
Copy link
Collaborator

No description provided.

@sebastien-lenard
Copy link
Collaborator Author

pre-commit.ci autofix

Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • labelPlotYaxis spelling should be unchanged
  • Boolean values true / false should not be quoted

@sebastien-lenard
Copy link
Collaborator Author

@MattF-NSIDC I corrected the files, but don't know where to check your reviews. And the pretty thing is still there, I don't why. I used this https://jsonformatter.org/json-pretty-print, but maybe the validator rejects \r\n (windows end of line)?

@mfisher87
Copy link
Member

pre-commit.ci autofix

@mfisher87
Copy link
Member

mfisher87 commented Feb 20, 2024

The validator we use is prettier (https://prettier.io/), and we're using pre-commit (https://pre-commit.com/) to run it. pre-commit.ci autofix runs it in CI. I think your post didn't work since its content is: [pre-commit.ci](http://pre-commit.ci/) autofix instead of just pre-commit.ci autofix.

Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sebastien-lenard sebastien-lenard merged commit 6981e44 into main Feb 20, 2024
3 checks passed
@sebastien-lenard sebastien-lenard deleted the sebastien-lenard-patch-1 branch February 20, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants