FixNPEIncremental #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls.getRealtimeSplits (apache#3994)
Co-authored-by: 闫杜峰 <yandufeng@sinochem.com>
… metrics are enabled (apache#3976)
Co-authored-by: yuezhang <yuezhang@freewheel.tv>
…ch has new partitions (apache#3947)
…res Maven >=3.3.1 to work properly); (apache#4009) Updated README
…strategy (apache#3950) * Enabling timeline server based markers * Enabling timeline server based markers and marker based rollback * Removing constraint that timeline server can be enabled only for hdfs * Fixing tests
Co-authored-by: 0x3E6 <dragon1996>
Co-authored-by: lubo <bollu@tencent.com>
- Co-authored-by: Wenning Ding <wenningd@amazon.com> - Co-authored-by: Sivabalan Narayanan <n.siva.b@gmail.com>
Co-authored-by: Wenning Ding <wenningd@amazon.com>
…ing back failed writes (apache#3956)
- Metadata table today has virtual keys disabled, thereby populating the metafields for each record written out and increasing the overall storage space used. Hereby adding virtual keys support for metadata table so that metafields are disabled for metadata table records. - Adding a custom KeyGenerator for Metadata table so as to not rely on the default Base/SimpleKeyGenerators which currently look for record key and partition field set in the table config. - AbstractHoodieLogRecordReader's version of processing next data block and createHoodieRecord() will be a generic version and making the derived class HoodieMetadataMergedLogRecordReader take care of the special creation of records from explictly passed in partition names.
…d TestHoodieCompactor (apache#4023)
…apache#4039) - Adding support for the metadata table to restore to first commit and take proper action for the bootstrap on subequent commits.
…#3359) Co-authored-by: Wenning Ding <wenningd@amazon.com>
…ilure (apache#4343)" (apache#4465) This reverts commit 7e7ad15.
…e#4470) * [HUDI-3083] Support component data types for flink bulk_insert * add nested row type test
Co-authored-by: yuzhaojing <yuzhaojing@bytedance.com>
…pache#3173) * [HUDI-2154] Add index key field to HoodieKey * [HUDI-2157] Add the bucket index and its read/write implemention of Spark engine. * revert HUDI-2154 add index key field to HoodieKey * fix all comments and introduce a new tricky way to get index key at runtime support double insert for bucket index * revert spark read optimizer based on bucket index * add the storage layout * index tag, hash function and add ut * fix ut * address partial comments * Code review feedback * add layout config and docs * fix ut * rename hoodie.layout and rebase master Co-authored-by: Vinoth Chandar <vinoth@apache.org>
Co-authored-by: yuzhaojing <yuzhaojing@bytedance.com>
…che#4454) * [HUDI-3095] abstract partition filter logic to enable code reuse * [HUDI-3095] address reviews
…hms (apache#4453) * constructDropPartitions when drop partitions using jdbc * done * done * code style * code review Co-authored-by: yuezhang <yuezhang@freewheel.tv>
apache#4493) Co-authored-by: yuezhang <yuezhang@freewheel.tv>
Update Spark 3 build instructions
…xception when records by keys (apache#4505) - HoodieMetadataMergedLogRecordReader#getRecordsByKeys() and its parent class methods are not thread safe. When multiple queries come in for gettting log records by keys, they all operate on the same log record reader instance provided by HoodieBackedTableMetadata#openReadersIfNeeded() and they trip over each other as they clear/put/get the same class memeber records. - The fix is to streamline the mutatation to class member records. Making HoodieMetadataMergedLogRecordReader#getRecordsByKeys() a synchronized method to avoid concurrent log records readers getting into NPE.
Co-authored-by: Nicolas Paris <nicolas.paris@adevinta.com>
* Closing LogRecordScanner in compactor * Addressing comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleDateFormatto be thread-safe ([HUDI-2831] Securing usages ofSimpleDateFormatto be thread-safe apache/hudi#4073)hoodie.table.keygenerator.class([HUDI-2818] Fix 2to3 upgrade when sethoodie.table.keygenerator.classapache/hudi#4077)PARTITIONPATH_FIELD_NAMEresulting in incorrectKeyGeneratorconfiguration ([HUDI-2911] Removing default value forPARTITIONPATH_FIELD_NAMEresulting in incorrectKeyGeneratorconfiguration apache/hudi#4195)Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.