Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell cleanup: dead code #103

Closed
wants to merge 1 commit into from
Closed

Conversation

CivBase
Copy link
Contributor

@CivBase CivBase commented Apr 14, 2015

Description:
Removed some dead code I found in cell.py. It is technically executed, but it is also overridden immediately after and does not affect the code in any meaningful way.

Reviewer(s):
@nskinkel

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 35.9% when pulling 4aedc01 on CivBase:clean_up_dead_code into 44441db on nskinkel:master.

@nskinkel nskinkel closed this in 096cf92 Apr 14, 2015
@nskinkel
Copy link
Owner

Good catch. I fixed this slightly differently than you did in your PR in 096cf92, but same idea. I prefer to assign things using meaningful constants where possible to help readers understand how we implement the protocol, so I just did that and removed the struct.calcsize() call entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants