Remove events variable assignment #135
Conversation
This commit removes a superfluous variable assignment in Goby::WorldComman#describe_tile. A variable "events" was being assigned, but not used in the #describe_tile function. This commit removes that variable assignment as a matter of keeping the code clean.
Remove events variable assignment
module Goby contains a private method `run_turn` that had a check at the
end of the function definition. While it is acceptable practice to use a
not operator ("!") before a function call, it can decrease the
readability of logic and increases cognitive overhead to understand the
meaning of the code. Creating a new private method `continue_game?`
makes explicit the purpose of that logic check at the end of the
`run_turn` method within the context of the game.
Add private method to enhance readability
|
Hi @mjvcallibrity - thanks a lot for the pull request. To say "A iff B" is to say that A is true if B is true, and vice versa. It's logically stronger than "A if B," which only covers the former statement. Change that part back to "iff" (or "if and only if"). You'll need to update that in your The type specified in the parameter documentation of your Finally, you'll need to merge the |
|
Hey, Many thanks for giving a clear explanation on the "A iff B" statement. I (obviously) didn't know about that before. I'll also be sure to update the parameter documentation on |
This PR removes a superfluous variable assignment in
Goby::WorldComman#describe_tile. A variable "events" was being assigned,
but not used in the #describe_tile function. This commit removes that
variable assignment as a matter of keeping the code clean.