Simplify library interfaces a bit #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbft requires PublicKey to be equatable, no marshaller or verification should be used by dbft library. Also, it's not very user-friendly to perform public key comparison via marshalling, and thus, this code is refactored. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
light-pubkey
branch
from
bc6e6c9
to
8508f7b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 62.72% 63.31% +0.58%
==========================================
Files 27 27
Lines 1532 1510 -22
==========================================
- Hits 961 956 -5
+ Misses 504 489 -15
+ Partials 67 65 -2 ☔ View full report in Codecov by Sentry. |
Either WithKeyPair or WithGetKeyPair should be kept. The latter is more general, thus I'm keeping it and removing the first setter. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
dbft package itself doesn't need anything from PublicKey. It's the user who is responsible for public keys comparison and WithGetKeyPair callback implementation. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
…ation Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
light-pubkey
branch
from
8508f7b
to
8e00eb3
Compare
roman-khimov
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just something I have on hands left after Neo X dependencies upgrade.