dbft: adjust timer setting by the block processing time #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make block timing more accurate under load. BlockIndex is needed to distinguish between consensus-produced block and the one added via regular block addition mechanism. See neo-project/neo#1959 and neo-project/neo#1960.
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 71.29% 71.50% +0.21%
==========================================
Files 24 24
Lines 1045 1053 +8
==========================================
+ Hits 745 753 +8
Misses 246 246
Partials 54 54
Continue to review full report at Codecov.
|
fyrchik
reviewed
Sep 25, 2020
| @@ -123,6 +123,14 @@ func (d *DBFT) InitializeConsensus(view byte) { | |||
| } else { | |||
| timeout = d.SecondsPerBlock << (d.ViewNumber + 1) | |||
| } | |||
| if d.lastBlockIndex+1 == d.BlockIndex { | |||
| var ts = d.Timer.Now() | |||
There was a problem hiding this comment.
¡No me gusta :=! Not that it's that big of a problem, though.
fyrchik
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make block timing more accurate under load. BlockIndex is needed to
distinguish between consensus-produced block and the one added via regular
block addition mechanism.
See neo-project/neo#1959 and neo-project/neo#1960.