Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bench to 3.7.4 and 0.106.0 version #176

Merged
merged 3 commits into from
May 30, 2024
Merged

Update bench to 3.7.4 and 0.106.0 version #176

merged 3 commits into from
May 30, 2024

Conversation

AnnaShaleva
Copy link
Member

@roman-khimov, I suggest not to touch Dockerfile.sharp.sources.from_binaries and Dockerfile.sharp.sources.from_local_dependencies because we need to remove one of them and completely refactor another one in the #175. We have Dockerfile.sharp that allows us to properly build the last non-mono released version, I think it's enough.

What do you think?

@AnnaShaleva
Copy link
Member Author

Also, we may wait until 0.106.0 is released, and I'll update this PR afterwards.

@roman-khimov
Copy link
Member

I suggest not to touch Dockerfile.sharp.sources.from_binaries and Dockerfile.sharp.sources.from_local_dependencies

I thought about making an interim version, but probably you're right, it won't allow to build master anyway, so we better have stable pre-built versions for now, tag them and then rework the build subsequently. What we need is some way to test master, so #175 is very much relevant for us in the near future.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for 0.106.0 proper.

@AnnaShaleva
Copy link
Member Author

Let's wait for 0.106.0 proper.

Updated, depends on #172 and #169.

@AnnaShaleva AnnaShaleva changed the title Update bench to 3.7.4 and pre-0.106.0 version Update bench to 3.7.4 and 0.106.0 version May 21, 2024
Close #151.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva AnnaShaleva merged commit 640bb24 into master May 30, 2024
8 checks passed
@AnnaShaleva AnnaShaleva deleted the 3.7.4-upd branch May 30, 2024 09:28
@AnnaShaleva
Copy link
Member Author

3.7.4 is tagged successfully, can move on with #175.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants