Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: adjust System.Contract.Call* interops #1181

Closed
AnnaShaleva opened this issue Jul 16, 2020 · 1 comment · Fixed by #1228
Closed

core: adjust System.Contract.Call* interops #1181

AnnaShaleva opened this issue Jul 16, 2020 · 1 comment · Fixed by #1228
Assignees
@fyrchik
Labels
feature Completely new functionality
Milestone
v0.91.0

Comments

@AnnaShaleva
Copy link
Member

AnnaShaleva commented Jul 16, 2020 •
edited
Loading

The following changes should be implement together:

  1. Adjust Manifest.ABI: remove EntryPoint, add Method.Offset (affects compiler also).
  2. Adjust getcontractstate RPC call: check JSON fields names.
  3. Adjust System.Contract.Call and System.Contract.CallEx interops:
    • contracts don't have EntryPoint anymore, there's a special _initialize method instead (affects compiler also)
    • invoke contract's methods using Manifest and offsets, not the Main function as it was before
@AnnaShaleva AnnaShaleva added feature Completely new functionality neo3 labels Jul 16, 2020
@AnnaShaleva AnnaShaleva mentioned this issue Jul 16, 2020
Merged
@roman-khimov roman-khimov added this to the v0.91.0 milestone Jul 16, 2020
@roman-khimov roman-khimov removed the neo3 label Jul 17, 2020
@roman-khimov
Copy link
Member

Don't forget neo-project/neo#1695 check.

This was referenced Jul 23, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fyrchik fyrchik

Labels
feature Completely new functionality
Projects
None yet
Milestone
v0.91.0
Development

Successfully merging a pull request may close this issue.

Adjust System.Contract.Call.* interops nspcc-dev/neo-go
3 participants
@fyrchik @roman-khimov @AnnaShaleva