Adjust System.Contract.Call.* interops
#1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1228 +/- ##
==========================================
+ Coverage 62.64% 66.83% +4.19%
==========================================
Files 200 200
Lines 17123 17148 +25
==========================================
+ Hits 10726 11461 +735
+ Misses 5810 5074 -736
- Partials 587 613 +26
Continue to review full report at Codecov.
|
AnnaShaleva
requested changes
Jul 24, 2020
Allow to generate manifest when using compiler as a library.
AnnaShaleva
requested changes
Jul 27, 2020
Generate proper manifest file too.
Exported functions should always be present in byte-code. This will be needed later when arbitrary method calls are allowed.
Allow to invoke methods by offset: 1. Every invoked contract must have manifest. 2. Check arguments count on invocation. 3. Change AppCall to a regular syscall. 4. Add test suite for `System.Contract.Call`.
Do not require contract hash to be known at compile time.
Abstract out (*VM).Call method and use in in CALL* opcodes.
When calling contract it must be provided with a new stack containing only it's arguments. The result is then copied back on RET. Fix #1220.
Invoke `_initialize` method on every call if present. In NEO3 there is no entrypoint and methods are invoked by offset, thus `Main` function is no longer required. We still have special `Main` method in tests to simplify them.
AnnaShaleva
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1181.
Close #1220.