Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: move transaction cosigners to signers #1184

Closed
AnnaShaleva opened this issue Jul 16, 2020 · 1 comment · Fixed by #1244
Closed

core: move transaction cosigners to signers #1184

AnnaShaleva opened this issue Jul 16, 2020 · 1 comment · Fixed by #1244
Assignees
@AnnaShaleva
Labels
feature Completely new functionality
Milestone
v0.91.0

Comments

@AnnaShaleva
Copy link
Member

Cosigners are Signers now (include transaction's sender). Related changes should be implemented:

  1. New witness scope FeeOnly.
  2. Take into account the number of signers while deserialising transaction's attributes.
  3. Adjust getrawtransaction RPC-call.
  4. Refactor transaction-related cli commands in order to include transaction sender in Signers list with FeeOnly witness scope (if needed).
@AnnaShaleva AnnaShaleva added feature Completely new functionality neo3 labels Jul 16, 2020
@AnnaShaleva AnnaShaleva mentioned this issue Jul 16, 2020
Closed
@roman-khimov roman-khimov added this to the v0.91.0 milestone Jul 16, 2020
@roman-khimov
Copy link
Member

include transaction sender in Signers list with FeeOnly witness scope (if needed).

Usually it's CalledByEntry, that's the whole point of this change. Though for deployments it can be FeeOnly.

@roman-khimov roman-khimov removed the neo3 label Jul 17, 2020
@AnnaShaleva AnnaShaleva self-assigned this Jul 29, 2020
AnnaShaleva added a commit that referenced this issue Jul 30, 2020
@AnnaShaleva
core: move transaction's sender to cosigners
28520a2 
Closes #1184

Ported changes from neo-project/neo#1752
@AnnaShaleva AnnaShaleva mentioned this issue Jul 30, 2020
Merged
AnnaShaleva added a commit that referenced this issue Aug 4, 2020
@AnnaShaleva
core: move transaction's sender to cosigners
dae7eef 
Closes #1184

Ported changes from neo-project/neo#1752
AnnaShaleva added a commit that referenced this issue Aug 4, 2020
@AnnaShaleva
core: move transaction's sender to cosigners
9c09743 
Closes #1184

Ported changes from neo-project/neo#1752
AnnaShaleva added a commit that referenced this issue Aug 4, 2020
@AnnaShaleva
core: move transaction's sender to cosigners
8d30a96 
Closes #1184

Ported changes from neo-project/neo#1752
AnnaShaleva added a commit that referenced this issue Aug 4, 2020
@AnnaShaleva
core: move transaction's sender to cosigners
90825ef 
Closes #1184

Ported changes from neo-project/neo#1752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnnaShaleva AnnaShaleva

Labels
feature Completely new functionality
Projects
None yet
Milestone
v0.91.0
Development

Successfully merging a pull request may close this issue.

core: move transaction sender to signers nspcc-dev/neo-go
2 participants
@roman-khimov @AnnaShaleva