Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move syscall handling out of VM #1237

Closed
fyrchik opened this issue Jul 28, 2020 · 0 comments · Fixed by #1238
Closed

Move syscall handling out of VM #1237

fyrchik opened this issue Jul 28, 2020 · 0 comments · Fixed by #1238
Labels
discussion Open discussion of some problem

Comments

@fyrchik
Copy link
Contributor

fyrchik commented Jul 28, 2020

Currently we have interop.Function and vm.InteropFuncPrice which intersect a bit.
The proposal is to replace vm.InteropFuncPrice and vm.(*VM).RegisterInteropGetter with a single v.Syscall field function, which accepts only syscall ID.
It will remove some code from the vm package (interop-related, public key cache, iterator and enumerator interops) and make syscall handling simpler and more flexible.
Thoughts @roman-khimov @AnnaShaleva ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Open discussion of some problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement System.Callback.* interops nspcc-dev/neo-go
1 participant
@fyrchik