Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github: adjust Push images to DockerHub workflow after Windows tests are fixed #2277

Closed
AnnaShaleva opened this issue Nov 25, 2021 · 0 comments · Fixed by #2353
Closed

.github: adjust Push images to DockerHub workflow after Windows tests are fixed #2277

AnnaShaleva opened this issue Nov 25, 2021 · 0 comments · Fixed by #2353
Labels
windows Windows platform
Milestone
v0.98.2

Comments

@AnnaShaleva
Copy link
Member

Currently publish_wsc job is always run after tests_wsc job even if the tests are failing. After #2268 and #2269 Windows-based tests will be repaired, so we need to remove ${{ always() }} condition from publish_wsc job.
@AnnaShaleva AnnaShaleva mentioned this issue Nov 25, 2021
Merged
2 tasks
@roman-khimov roman-khimov added this to the v0.98.2 milestone Jan 31, 2022
@roman-khimov roman-khimov added the windows Windows platform label Feb 8, 2022
AnnaShaleva added a commit that referenced this issue Feb 9, 2022
@AnnaShaleva
github: fix publishing job for WSC image
5a521ae 
Close #2277.
AnnaShaleva added a commit that referenced this issue Feb 9, 2022
@AnnaShaleva
github: fix publishing job for WSC image
f0149f6 
Close #2277.
AnnaShaleva added a commit that referenced this issue Feb 10, 2022
@AnnaShaleva
github: fix publishing job for WSC image
8c91546 
Close #2277.
AnnaShaleva added a commit that referenced this issue Feb 10, 2022
@AnnaShaleva
github: fix publishing job for WSC image
207441f 
Close #2277.
AnnaShaleva added a commit that referenced this issue Feb 10, 2022
@AnnaShaleva
github: fix publishing job for WSC image
0e67505 
Close #2277.
@AnnaShaleva AnnaShaleva mentioned this issue Feb 10, 2022
Merged
AnnaShaleva added a commit that referenced this issue Feb 10, 2022
@AnnaShaleva
github: fix publishing job for WSC image
d0054f4 
Close #2277.
AnnaShaleva added a commit that referenced this issue Feb 10, 2022
@AnnaShaleva
github: fix publishing job for WSC image
2cf15ea 
Close #2277.
AnnaShaleva added a commit that referenced this issue Feb 17, 2022
@AnnaShaleva
github: fix publishing job for WSC image
29a70fc 
Close #2277.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
windows Windows platform
Projects
None yet
Milestone
v0.98.2
Development

Successfully merging a pull request may close this issue.

*: fix windows tests nspcc-dev/neo-go
2 participants
@roman-khimov @AnnaShaleva