Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move config.go out of config/ #423

Closed
roman-khimov opened this issue Oct 14, 2019 · 1 comment · Fixed by #810
Closed

Move config.go out of config/ #423

roman-khimov opened this issue Oct 14, 2019 · 1 comment · Fixed by #810
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v0.75.0

Comments

@roman-khimov
Copy link
Member

I don't think there should be anything but configuration files in the config directory, so config.go should go somewhere else. IMO it would also be nice to move parts of it into respective packages like we already did with configs for various DBs.
@roman-khimov roman-khimov added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 23, 2019
@roman-khimov
Copy link
Member Author

See ServerConfig in pkg/network also, this one should be integrated well into the overall config structure.

@roman-khimov roman-khimov added this to the v0.74.1 milestone Mar 16, 2020
AnnaShaleva added a commit that referenced this issue Mar 31, 2020
@AnnaShaleva
config: move config.go out of config/
4f3c97b 
closes #423
AnnaShaleva added a commit that referenced this issue Mar 31, 2020
@AnnaShaleva
config: move config.go out of config/
d5435a0 
closes #423
AnnaShaleva added a commit that referenced this issue Mar 31, 2020
@AnnaShaleva
config: move config.go out of config/
e5d1d8f 
closes #423
AnnaShaleva added a commit that referenced this issue Mar 31, 2020
@AnnaShaleva
config: move config.go out of config/
76414c5 
closes #423
@AnnaShaleva AnnaShaleva mentioned this issue Mar 31, 2020
Merged
AnnaShaleva added a commit that referenced this issue Mar 31, 2020
@AnnaShaleva
config: move config.go out of config/
8a227cf 
closes #423
AnnaShaleva added a commit that referenced this issue Mar 31, 2020
@AnnaShaleva
config: move config.go out of config/
5a984fd 
closes #423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v0.75.0
Development

Successfully merging a pull request may close this issue.

config: move config.go out of config nspcc-dev/neo-go
2 participants
@fyrchik @roman-khimov