Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/state: use more compact representation for state.AppExecResult.Stack #782

Closed
fyrchik opened this issue Mar 19, 2020 · 1 comment · Fixed by #787
Closed

core/state: use more compact representation for state.AppExecResult.Stack #782

fyrchik opened this issue Mar 19, 2020 · 1 comment · Fixed by #787
Assignees
Labels
rpc RPC server and client
Milestone

Comments

@fyrchik
Copy link
Contributor

fyrchik commented Mar 19, 2020

RN state.AppExecResult contains Stack string which is vm's stack marshalled to indented (!) JSON (!). Because it is saved in DB, it is better to have some compact binary representation and marshal to JSON when returning to use (i.e. in RPC).

@roman-khimov
Copy link
Member

It was done to quickly add functionality before the stack parameter types merge was done. I think now we can reuse (*Stack).ToContractParameters and store those. IIRC it already has the right JSON output format for this thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc RPC server and client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants