Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MPT #851

Closed
roman-khimov opened this issue Apr 13, 2020 · 2 comments · Fixed by #1235
Closed

Implement MPT #851

roman-khimov opened this issue Apr 13, 2020 · 2 comments · Fixed by #1235
Assignees
@fyrchik
Milestone
v0.91.0

Comments

@roman-khimov
Copy link
Member

See neo-project/neo#1383, neo-project/neo#1442, neo-project/neo#1560. I think we should make it a module built around Store, but not as a proxy as it's done in C# implementation. We're better adding it to DAO and explicitly pushing changes being done to storage, in theory it can even allow us to make MPT calculations asynchronous (with synchronization on Persist).
@roman-khimov roman-khimov mentioned this issue May 21, 2020
Closed
@roman-khimov
Copy link
Member Author

Let this one stay for master.

@roman-khimov roman-khimov added this to the v0.91.0 milestone Jul 17, 2020
@roman-khimov
Copy link
Member Author

We can add the MPT itself (with all the fixes) for 0.91.0, but not add P2P/consensus changes, just cherry-pick appropriate commits (like neo-project#1442 did).

@fyrchik fyrchik mentioned this issue Jul 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fyrchik fyrchik

Labels
None yet
Projects
None yet
Milestone
v0.91.0
Development

Successfully merging a pull request may close this issue.

Implement MPT nspcc-dev/neo-go
2 participants
@fyrchik @roman-khimov