Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MPT for neox-2.x #964

Closed
roman-khimov opened this issue May 20, 2020 · 2 comments
Closed

Implement MPT for neox-2.x #964

roman-khimov opened this issue May 20, 2020 · 2 comments
Assignees
Milestone

Comments

@roman-khimov
Copy link
Member

We need to implement MPT for neox-2.x branch starting with neo-project/neo#1560 changes (and any updates of this basic building block). It will also be a separate branch for now, but we need to be prepared for Neo 2 changes and it's also gonna be the base for Neo 3 MPT implementation.

We'll also need to implement key grouping for this to work (or actually move the appropriate code from CLI), the end goal is to be compatible with C# implementation and it mangles keys a little when storing them. I'd suggest keeping that at MPT layer and not changing our actual storage keys (keeping DBs compatible).

It shouldn't be a wrapper around DB (as in C#) but rather a user of Store that DAO can use for some of its methods. And it'd be nice to not have these calculations in dao.Cached because they're not exactly fast and they're not needed for every change (we care mostly about block-level changes at the moment).

@roman-khimov
Copy link
Member Author

See also #851.

@roman-khimov roman-khimov added this to the v0.75.1-neox1 milestone May 30, 2020
@roman-khimov
Copy link
Member Author

Fixed with #990.

@roman-khimov roman-khimov modified the milestones: v0.75.1-neox1, v0.76.0 Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants