Consensus fixes 2.x neox #1041
Merged
Consensus fixes 2.x neox #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using view number from the recovery message is just plain wrong, it's gonna be higher than our current view and these messages will be treated as coming from the future, even though they have their original view number included.
Include logging updates and LastSeenMessages fix.
Codecov Report
@@ Coverage Diff @@
## neox-2.x #1041 +/- ##
============================================
- Coverage 68.10% 68.09% -0.02%
============================================
Files 158 158
Lines 15337 15338 +1
============================================
- Hits 10446 10444 -2
- Misses 4384 4387 +3
Partials 507 507
Continue to review full report at Codecov.
|
fyrchik
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dbft and fix recovery message processing.