Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: make EQUAL type strict #1225

Merged
merged 1 commit into from
Jul 23, 2020
Merged

vm: make EQUAL type strict #1225

merged 1 commit into from
Jul 23, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Jul 23, 2020

Do not perform type conversions when comparing elements.
Close #1211 .

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #1225 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1225      +/-   ##
==========================================
- Coverage   66.79%   66.76%   -0.04%     
==========================================
  Files         199      199              
  Lines       17011    17005       -6     
==========================================
- Hits        11363    11353      -10     
- Misses       5034     5038       +4     
  Partials      614      614              
Impacted Files Coverage Δ
pkg/vm/stackitem/item.go 90.04% <100.00%> (-0.56%) ⬇️
pkg/rpc/client/wsclient.go 83.22% <0.00%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18dcc16...9252ef6. Read the comment docs.

Do not perform type conversions when comparing elements.
@roman-khimov roman-khimov merged commit a45c160 into master Jul 23, 2020
@roman-khimov roman-khimov deleted the fix/equal branch July 23, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change EQUALS logic to post-preview2 VM
3 participants