Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: filter subscriptions' notifications by name #1266

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

AnnaShaleva
Copy link
Member

Closes #1263

@AnnaShaleva AnnaShaleva added the rpc RPC server and client label Aug 4, 2020
@AnnaShaleva AnnaShaleva self-assigned this Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #1266 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1266   +/-   ##
=======================================
  Coverage   67.77%   67.77%           
=======================================
  Files         215      215           
  Lines       18297    18299    +2     
=======================================
+ Hits        12401    12403    +2     
  Misses       5238     5238           
  Partials      658      658           
Impacted Files Coverage Δ
pkg/rpc/request/param.go 92.36% <ø> (ø)
pkg/rpc/client/wsclient.go 84.56% <100.00%> (ø)
pkg/rpc/server/subscription.go 96.96% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d41c7...4ff3a9e. Read the comment docs.

@roman-khimov roman-khimov merged commit 4bbe863 into master Aug 5, 2020
@roman-khimov roman-khimov deleted the notifications/filter_by_name branch August 5, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter events by name
2 participants