Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getutxotransfers RPC (2.x) #1268

Merged
merged 5 commits into from
Aug 6, 2020
Merged

Implement getutxotransfers RPC (2.x) #1268

merged 5 commits into from
Aug 6, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Aug 4, 2020

Reuse NEP5TransferLog for everything.

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #1268 into master-2.x will decrease coverage by 0.20%.
The diff coverage is 54.27%.

Impacted file tree graph

@@              Coverage Diff               @@
##           master-2.x    #1268      +/-   ##
==============================================
- Coverage       67.93%   67.73%   -0.21%     
==============================================
  Files             159      160       +1     
  Lines           15601    15876     +275     
==============================================
+ Hits            10599    10754     +155     
- Misses           4478     4583     +105     
- Partials          524      539      +15     
Impacted Files Coverage Δ
pkg/core/dao/dao.go 39.61% <0.00%> (-4.12%) ⬇️
pkg/core/storage/store.go 34.61% <ø> (ø)
pkg/core/dao/cacheddao.go 30.83% <27.58%> (-0.39%) ⬇️
pkg/core/blockchain.go 45.54% <50.00%> (+0.34%) ⬆️
pkg/core/state/transfer_log.go 50.00% <50.00%> (ø)
pkg/core/state/nep5.go 52.94% <85.71%> (-0.69%) ⬇️
pkg/rpc/server/server.go 84.01% <97.89%> (+1.49%) ⬆️
pkg/rpc/client/wsclient.go 85.71% <0.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e135719...7bd4488. Read the comment docs.

pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/core/state/transfer_log.go Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
Traversing transfer log instead of accumulating and returning it
is faster and takes less memory.
@roman-khimov roman-khimov merged commit 9aa7b7f into master-2.x Aug 6, 2020
@roman-khimov roman-khimov deleted the feature/utxo branch August 6, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants