Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: adjust getutxotransfers RPC #1288

Merged
merged 1 commit into from
Aug 7, 2020
Merged

rpc: adjust getutxotransfers RPC #1288

merged 1 commit into from
Aug 7, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Aug 7, 2020

Close #1287 .
The only thing that bothers me is that total_amount field is somewhat meaningless now.

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #1288 into master-2.x will decrease coverage by 0.07%.
The diff coverage is 62.50%.

Impacted file tree graph

@@              Coverage Diff               @@
##           master-2.x    #1288      +/-   ##
==============================================
- Coverage       67.75%   67.68%   -0.08%     
==============================================
  Files             160      160              
  Lines           15892    15851      -41     
==============================================
- Hits            10768    10729      -39     
- Misses           4584     4588       +4     
+ Partials          540      534       -6     
Impacted Files Coverage Δ
pkg/core/state/transfer_log.go 50.00% <50.00%> (ø)
pkg/core/blockchain.go 44.55% <56.00%> (-1.00%) ⬇️
pkg/rpc/server/server.go 83.92% <100.00%> (-0.14%) ⬇️
pkg/core/mpt/trie.go 92.43% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92851aa...57a325b. Read the comment docs.

@roman-khimov roman-khimov merged commit ffbdcb2 into master-2.x Aug 7, 2020
@roman-khimov roman-khimov deleted the fix/utxo branch August 7, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UTXO tracking for 2.x
2 participants