Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port getnep5transfers changes to master #1289

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Port getnep5transfers changes to master #1289

merged 2 commits into from
Aug 10, 2020

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Aug 7, 2020

Close #1280 .

  1. Replace GetNEP5TransferLog with ForEachNEP5Transfer.
  2. Allow to use timestamps in the request. (they are now in ms).

@fyrchik
core: do not store NEP5 transfer log in memory
807338f 
Traversing transfer log instead of accumulating and returning it
is faster and takes less memory.
@fyrchik
rpc: provide timestamps in getnep5transfers
412fc53 
Set default value for the first timestamp to a week ago.
@roman-khimov roman-khimov merged commit 4aeaf05 into master Aug 10, 2020
@roman-khimov roman-khimov deleted the fix/nep5 branch August 10, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

Assignees
No one assigned
Labels
rpc RPC server and client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update getnep5transfers with Neo 2 improvements
3 participants
@fyrchik @roman-khimov @AnnaShaleva