examples: update examples #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
force-pushed
the
smartcontract/examples
branch
from
0760b62
to
39ae811
Compare
Codecov Report
@@ Coverage Diff @@
## master #1296 +/- ##
==========================================
+ Coverage 65.72% 68.20% +2.47%
==========================================
Files 217 217
Lines 18564 18570 +6
==========================================
+ Hits 12201 12665 +464
+ Misses 5703 5220 -483
- Partials 660 685 +25
Continue to review full report at Codecov.
|
AnnaShaleva
force-pushed
the
smartcontract/examples
branch
4 times, most recently
from
f4099e1
to
f8caf4e
Compare
roman-khimov
requested changes
Aug 10, 2020
AnnaShaleva
force-pushed
the
smartcontract/examples
branch
3 times, most recently
from
d7af951
to
1e5150c
Compare
We currently can't process events in codegen, so we have to provide them via .yml config file. Do not delete the rest of the code connected with conversion of MethodDebugInfo.Event into manifest.Event as we have issue #1038.
roman-khimov
requested changes
Aug 11, 2020
We don't have totalSupply in contract storage because we did't put it there. Fixed.
AnnaShaleva
force-pushed
the
smartcontract/examples
branch
from
1e5150c
to
e2b22bc
Compare
roman-khimov
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1234