Various preview3 testnet fixes #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes missing an error on block addition when the header actually went it, but the block didn't.
It's no longer needed (yay!)
Empty byte array is enough to be bigint value of zero. Fixes state differences with C# node.
There is a huge difference between "result" : [], and "result" : null,
C# doesn't do that since neo-project/neo#1762.
We're collecting dbft.M() number of signatures in getBlockWitness(), so we should use the same value for M here.
And use it where appropriate. Some of our code was just plain wrong (like the one in GAS contract) and unification is always useful here.
fyrchik
approved these changes
Aug 10, 2020
As it's returned sorted now. Fixes state change mismatch for NextValidators. It also partially reverts 2f8e7e4 and significantly changes the test chain as the fees are no longer being sent to the same account.
roman-khimov
force-pushed
the
various-preview3-fixes
branch
from
71fc3d1
to
c16040a
Compare
AnnaShaleva
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Preview3 testnet.
Solution
This makes us compatible wrt storage changes up to 33K of blocks which is the current testnet height.