Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup some old code #1303

Merged
merged 8 commits into from
Aug 12, 2020
Merged

Cleanup some old code #1303

merged 8 commits into from
Aug 12, 2020

Conversation

roman-khimov
Copy link
Member

Problem

Old dead code.

Solution

Remove it and fix transaction's attributes.

@roman-khimov roman-khimov added this to the v0.91.0 milestone Aug 11, 2020
It's not very useful especially given that we have proper neo-bench now.
@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #1303 into master will increase coverage by 0.16%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
+ Coverage   68.15%   68.32%   +0.16%     
==========================================
  Files         216      214       -2     
  Lines       18561    18438     -123     
==========================================
- Hits        12650    12597      -53     
+ Misses       5225     5159      -66     
+ Partials      686      682       -4     
Impacted Files Coverage Δ
pkg/core/blockchain.go 67.69% <ø> (+0.55%) ⬆️
pkg/core/dao/dao.go 68.66% <ø> (+5.34%) ⬆️
pkg/core/header_hash_list.go 68.75% <0.00%> (+13.75%) ⬆️
pkg/core/transaction/attribute.go 0.00% <0.00%> (-37.50%) ⬇️
pkg/rpc/client/rpc.go 79.39% <ø> (+1.87%) ⬆️
pkg/core/dao/cacheddao.go 81.33% <100.00%> (+13.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddf0bfb...ca542f1. Read the comment docs.

@roman-khimov roman-khimov merged commit 483eed1 into master Aug 12, 2020
@roman-khimov roman-khimov deleted the some-cleanup branch August 12, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants