Debugger compatibility fixes #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debugger expects it to be ByteArray. C# compiler also compiles it as `ByteArray` (in both manifest and debug.json). The previous commit 6a21612 changed this line as C# implementation serializes Blockchain.ApplicationExecuted.Stack as array of stackitem.Item and deserializes it as array of smartcontract.Parameter.
Codecov Report
@@ Coverage Diff @@
## master #1311 +/- ##
==========================================
- Coverage 68.30% 68.27% -0.03%
==========================================
Files 214 214
Lines 18443 18454 +11
==========================================
+ Hits 12597 12599 +2
- Misses 5164 5173 +9
Partials 682 682
Continue to review full report at Codecov.
|
roman-khimov
approved these changes
Aug 12, 2020
fyrchik
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.