core: fix getOnPersistWrapper for native contracts #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1331 +/- ##
==========================================
+ Coverage 68.30% 68.33% +0.03%
==========================================
Files 216 216
Lines 18584 18587 +3
==========================================
+ Hits 12694 12702 +8
+ Misses 5201 5198 -3
+ Partials 689 687 -2
Continue to review full report at Codecov.
|
pkg/core/native/native_nep5.go
Outdated
| return stackitem.NewBool(f(ic) == nil) | ||
| err := f(ic) | ||
| if err != nil { | ||
| panic(fmt.Errorf("error during calling OnPersist for native contract: %w", err)) |
There was a problem hiding this comment.
I think error during calling can be safely omitted here.
According to manifest, OnPersist.ReturnType is void, so we shouldn't return anything from it. It's not so important, as we drop this value at the end of OnPersist invocation.
AnnaShaleva
force-pushed
the
persist-fix
branch
from
279ebb1
to
591f639
Compare
roman-khimov
approved these changes
Aug 18, 2020
fyrchik
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to manifest, OnPersist.ReturnType is void, so we shouldn't
return anything from it. It's not so important, as we drop this value at
the end of OnPersist invocation.