Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: payloads from recovery messages are network-dependent too #1334

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

roman-khimov
Copy link
Member

Fixes wrong hash calculated for prepare request leading to bad prepare
response and inability to run heterogeneous 2+2 Go/C# nodes consensus.

Fixes wrong hash calculated for prepare request leading to bad prepare
response and inability to run heterogeneous 2+2 Go/C# nodes consensus.
@roman-khimov roman-khimov added bug Something isn't working consensus dBFT consensus labels Aug 18, 2020
@roman-khimov roman-khimov added this to the v0.91.0 milestone Aug 18, 2020
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #1334 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1334      +/-   ##
==========================================
+ Coverage   68.30%   68.34%   +0.03%     
==========================================
  Files         216      216              
  Lines       18584    18585       +1     
==========================================
+ Hits        12694    12702       +8     
+ Misses       5201     5197       -4     
+ Partials      689      686       -3     
Impacted Files Coverage Δ
pkg/consensus/recovery_message.go 84.52% <100.00%> (+0.09%) ⬆️
pkg/smartcontract/parameter.go 83.55% <0.00%> (+1.00%) ⬆️
pkg/rpc/client/wsclient.go 84.56% <0.00%> (+1.34%) ⬆️
pkg/core/native/blocked_accounts.go 75.00% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58af143...7db4ac4. Read the comment docs.

@roman-khimov roman-khimov merged commit 6cc6109 into master Aug 18, 2020
@roman-khimov roman-khimov deleted the fix-recovery-message-payload-decoding branch August 18, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working consensus dBFT consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants