Update GAS distribution logic, part1 #1364
Conversation
pkg/core/native/native_neo.go
Outdated
| if !n.votesChanged.Load().(bool) { | ||
| return nil | ||
| } | ||
| pubs, err := n.GetValidatorsInternal(ic.Chain, ic.DAO) | ||
| pubs, err = n.GetValidatorsInternal(ic.Chain, ic.DAO) |
There was a problem hiding this comment.
It'd be nice to split GetValidatorsInternal to not call GetCommitteeMembers() twice (it has some cost to it).
There was a problem hiding this comment.
Fixed (GetCommitteeMembers is not cached)
There was a problem hiding this comment.
But I don't see any change wrt this issue.
There was a problem hiding this comment.
Added committee caching.
|
Linter still isn't happy. |
Codecov Report
@@ Coverage Diff @@
## master #1364 +/- ##
==========================================
+ Coverage 70.29% 76.85% +6.56%
==========================================
Files 219 219
Lines 16890 17012 +122
==========================================
+ Hits 11873 13075 +1202
+ Misses 4295 3063 -1232
- Partials 722 874 +152
Continue to review full report at Codecov.
|
|
Please, rebase it. It's outdated a little wrt C# implementation, but it's a nice starting point. |
|
I don't see changes from neo-project/neo#1884 there (like PostPersist). Same thing with neo-project/neo#1917. |
|
@roman-khimov changes in neo-project/neo#1917 are overriden by ones from neo-project/neo#1920 . I wanted to do |
Update frequency depends on committee size and amount of validators. For mainnet it is 28.
It should be called for NEO contract to distribute committee bounties.
Related #1348 .
Implement distribution to NEO holders and validators.