Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #140 (improve error messages) #142

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Fix #140 (improve error messages) #142

merged 1 commit into from
Feb 20, 2019

Conversation

im-kulikov
Copy link
Contributor

@im-kulikov
Fix nspcc-dev#140 (improve error message)
09acaf9 
- return errors like in C# code (neo-project/neo#587)
- update tests
- small refactoring
@im-kulikov
Copy link
Contributor Author

@decentralisedkev / @fabwa any thoughts?

fyrchik
fyrchik approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@fyrchik fyrchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed, that assert.Equal is used for comparing json's. assert.JSONEq seems more suitable here to me. Could you change it?

@im-kulikov
Copy link
Contributor Author

I have noticed, that assert.Equal is used for comparing json's. assert.JSONEq seems more suitable here to me. Could you change it?

I think it would be better to do it in a separate PR, don't you think?

@im-kulikov im-kulikov mentioned this pull request Feb 20, 2019
Closed
@im-kulikov
Copy link
Contributor Author

I add issue for your proposal #155

@kevaundray kevaundray merged commit 20bb05b into nspcc-dev:master Feb 20, 2019
@im-kulikov im-kulikov deleted the fix/improve-error-message-#140 branch February 20, 2019 16:29
@hal0x2328 hal0x2328 added the I2 Regular impact label Feb 26, 2019
@hal0x2328
Copy link
Contributor

Award im-kulikov 150 points
Award fyrchik 30 points for review

@hal0x2328 hal0x2328 added this to Pending Distribution in Awards Distribution Feb 26, 2019
@lllwvlvwlll lllwvlvwlll moved this from Pending Distribution to In Progress in Awards Distribution Mar 10, 2019
@lllwvlvwlll
Copy link

https://neoscan.io/transaction/144dc06fbc54dd84165af08ddd9c01e8a720ca1bb05471dfd1af1503160f245f

@lllwvlvwlll lllwvlvwlll moved this from In Progress to Distributed in Awards Distribution Mar 10, 2019
@metachris metachris removed this from Distributed in Awards Distribution Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fyrchik fyrchik fyrchik approved these changes

Assignees
No one assigned
Labels
I2 Regular impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@im-kulikov @hal0x2328 @lllwvlvwlll @fyrchik @kevaundray