native: implement designate contract history retention #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it could reuse |
Codecov Report
@@ Coverage Diff @@
## master #1519 +/- ##
==========================================
+ Coverage 77.46% 77.48% +0.01%
==========================================
Files 229 229
Lines 17801 17843 +42
==========================================
+ Hits 13790 13825 +35
- Misses 3056 3058 +2
- Partials 955 960 +5
Continue to review full report at Codecov.
|
AnnaShaleva
approved these changes
Nov 6, 2020
fyrchik
reviewed
Nov 6, 2020
pkg/core/native_designate_test.go
Outdated
Comment on lines
67
to
72
| emit.Int(w.BinWriter, int64(index)) | ||
| emit.Int(w.BinWriter, int64(r)) | ||
| emit.Int(w.BinWriter, 2) | ||
| emit.Opcodes(w.BinWriter, opcode.PACK) | ||
| emit.String(w.BinWriter, "getDesignatedByRole") | ||
| emit.AppCall(w.BinWriter, bc.contracts.Designate.Hash) |
There was a problem hiding this comment.
emit.AppCallWIthOperationAndArgs ?
There was a problem hiding this comment.
Yeah, I had this thought. Fixed.
fyrchik
approved these changes
Nov 6, 2020
Follow neo-project/neo#2007. Fix getDesignatedByRole price along the way.
roman-khimov
force-pushed
the
designate-role-history
branch
from
b88c7bd
to
9e781bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow neo-project/neo#2007. Fix getDesignatedByRole price along the way.