Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: add System.Contract.CreateMultisigAccount #1763

Merged
merged 2 commits into from
Feb 19, 2021
Merged

core: add System.Contract.CreateMultisigAccount #1763

merged 2 commits into from
Feb 19, 2021

Conversation

AnnaShaleva
Copy link
Member

Close #1576.

@codecov
Copy link

codecov bot commented Feb 18, 2021 •
edited
Loading

Codecov Report

Merging #1763 (ed426c0) into master (fe918e2) will increase coverage by 0.07%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1763      +/-   ##
==========================================
+ Coverage   82.61%   82.69%   +0.07%     
==========================================
  Files         271      271              
  Lines       22140    22155      +15     
==========================================
+ Hits        18290    18320      +30     
+ Misses       2725     2711      -14     
+ Partials     1125     1124       -1
Impacted Files Coverage Δ
pkg/core/interops.go 100.00% <ø> (ø)
pkg/interop/contract/contract.go 0.00% <0.00%> (ø)
pkg/core/interop_system.go 95.23% <100.00%> (+0.59%) ⬆️
pkg/consensus/consensus.go 70.57% <0.00%> (+0.60%) ⬆️
pkg/smartcontract/contract.go 90.47% <0.00%> (+9.52%) ⬆️
pkg/core/interop/json/json.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe918e2...c82b11e. Read the comment docs.

fyrchik
fyrchik reviewed Feb 19, 2021
View reviewed changes
pkg/core/interops.go
@@ -43,6 +43,7 @@ var systemInterops = []interop.Function{
{Name: interopnames.SystemContractCall, Func: contract.Call, Price: 1 << 15,
RequiredFlags: callflag.AllowCall, ParamCount: 4},
{Name: interopnames.SystemContractCallNative, Func: native.Call, Price: 0, ParamCount: 1},
{Name: interopnames.SystemContractCreateMultisigAccount, Func: contractCreateMultisigAccount, Price: 1 << 8, ParamCount: 1},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is should be a bit more expensive that Standard equivalent. 1 << 9?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In C# node the price is 1<<8, but I also thought about it. Create an issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prices are not that important for us though key decoding is not free and it there can be a lot of keys there, so fair price relative to Standard is probably higher.

@roman-khimov roman-khimov merged commit 61e04f0 into master Feb 19, 2021
@roman-khimov roman-khimov deleted the multisig-interop branch February 19, 2021 15:15
This was referenced Feb 24, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@fyrchik fyrchik Awaiting requested review from fyrchik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional tests for node/contract/wallet CLI functionality
3 participants
@AnnaShaleva @fyrchik @roman-khimov