util: reduce allocations in util.Uint256DecodeStringLE
#2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is used a lot in clients (including our benchmark). `Uint160` is already optimized. ``` name old time/op new time/op delta Uint256DecodeStringLE-8 150ns ±15% 112ns ± 3% -25.23% (p=0.000 n=10+10) name old alloc/op new alloc/op delta Uint256DecodeStringLE-8 96.0B ± 0% 64.0B ± 0% -33.33% (p=0.000 n=10+10) name old allocs/op new allocs/op delta Uint256DecodeStringLE-8 2.00 ± 0% 1.00 ± 0% -50.00% (p=0.000 n=10+10) ``` Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
Codecov Report
@@ Coverage Diff @@
## master #2133 +/- ##
==========================================
+ Coverage 83.91% 83.98% +0.07%
==========================================
Files 290 290
Lines 27336 27337 +1
==========================================
+ Hits 22938 22960 +22
+ Misses 3131 3108 -23
- Partials 1267 1269 +2
Continue to review full report at Codecov.
|
roman-khimov
approved these changes
Aug 17, 2021
AnnaShaleva
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is used a lot in clients (including our benchmark).
Uint160is already optimized.Another reasonable step would be to use
hex.Decodeinstead ofDecodeStringbut then string is converted to[]byteargument so there is still 1 allocation.Signed-off-by: Evgeniy Stratonikov evgeniy@nspcc.ru