subscriptions: add container hash to notification event #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2192 +/- ##
==========================================
+ Coverage 83.72% 83.77% +0.04%
==========================================
Files 296 297 +1
Lines 28319 28347 +28
==========================================
+ Hits 23711 23747 +36
+ Misses 3259 3242 -17
- Partials 1349 1358 +9
Continue to review full report at Codecov.
|
fyrchik
approved these changes
Sep 24, 2021
Comment on lines
19
to
20
| // appExecResultAux is an auxiliary struct for JSON marshalling. | ||
| type notificationEventAux struct { |
pkg/rpc/response/events.go
Outdated
Comment on lines
11
to
12
| // NotaryRequestEvent represents P2PNotaryRequest event either added or removed | ||
| // from notary payload pool. |
There was a problem hiding this comment.
Comment should also be moved.
External users make use of it. Close #2190.
It is used for subscriptions only, so move it to the subscriptions pkg.
AnnaShaleva
force-pushed
the
rpc/container_hash
branch
from
1d134e9
to
5c97e0d
Compare
roman-khimov
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External users make use of it. Close #2190.