Drop NEPXXTokenInfo from the RPC client #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's the same, even though standards define parameter name in a bit different way.
I'm still not sure it's good to have this exposed from neptoken at all, but let's try it this way.
In the same way we do for NEP-17 tokens. This code predates "getnep11balances" call, so this wasn't possible back then, but now we can improve the situation (allow specifying names/symbols instead of hashes only).
We have this data available since 0.99.1 while all public networks require at least 0.99.2 for compatibility and NeoFS setups use 0.99.2+ too. This data can simplify account handling considerably making additional requests unneccessary in many cases.
roman-khimov
force-pushed
the
rpc-nep-token-info
branch
from
edc0c53
to
b0645fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #2667 +/- ##
==========================================
+ Coverage 85.07% 85.21% +0.14%
==========================================
Files 315 321 +6
Lines 38889 39285 +396
==========================================
+ Hits 33083 33475 +392
- Misses 4464 4474 +10
+ Partials 1342 1336 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AnnaShaleva
reviewed
Aug 30, 2022
1. In the single token mode compare known hashes instead of names, names can be misleading. 2. Hardcode NEO/GAS, they are special (if not overrided by the wallet data).
Make NEP-11 code use getnep11balances the same way NEP-17 code uses getnep17balances. This command was introduced well before getnep11balances appeared, so it required always specifying contract explicitly. Now this constraint can be relaxed somewhat in most cases.
roman-khimov
force-pushed
the
rpc-nep-token-info
branch
from
b0645fa
to
1da4b33
Compare
AnnaShaleva
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And update CLI commands. I think that's the last one for №4 from #2597.