Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: do not allow negative validators/committee count #2968

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

AnnaShaleva
Copy link
Member

Close #2946.

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #2968 (a74454a) into master (37f7c9d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2968   +/-   ##
=======================================
  Coverage   84.86%   84.86%           
=======================================
  Files         329      329           
  Lines       43028    43034    +6     
=======================================
+ Hits        36515    36521    +6     
  Misses       5028     5028           
  Partials     1485     1485           
Impacted Files Coverage Δ
pkg/neorpc/result/version.go 100.00% <ø> (ø)
pkg/config/protocol_config.go 92.35% <100.00%> (+0.30%) ⬆️
pkg/rpcclient/actor/maker.go 97.02% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

docs/node-configuration.md Outdated Show resolved Hide resolved
docs/node-configuration.md Outdated Show resolved Hide resolved
docs/node-configuration.md Outdated Show resolved Hide resolved
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@roman-khimov roman-khimov merged commit a875409 into master Apr 13, 2023
@roman-khimov roman-khimov deleted the bad-cfg-panic branch April 13, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node starts with bad config and panics
2 participants