Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: allow to create incremental dumps #3047

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

roman-khimov
Copy link
Member

Anything not starting from 0 is incremental by definition.

Anything not starting from 0 is incremental by definition.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov roman-khimov added this to the v0.102.0 milestone Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #3047 (bfe8867) into master (9185820) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3047      +/-   ##
==========================================
+ Coverage   84.61%   84.63%   +0.01%     
==========================================
  Files         329      329              
  Lines       43779    43791      +12     
==========================================
+ Hits        37044    37061      +17     
+ Misses       5230     5225       -5     
  Partials     1505     1505              
Impacted Files Coverage Δ
cli/server/server.go 68.91% <100.00%> (+0.16%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for intrusion, but I've added a test for this in a separate commit. LGTM.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva
Copy link
Member

I'd say it's a bug, because you can't create valid incremental dump without this patch.

@AnnaShaleva AnnaShaleva added the bug Something isn't working label Jul 6, 2023
@AnnaShaleva AnnaShaleva merged commit 68ad542 into master Jul 6, 2023
14 of 18 checks passed
@AnnaShaleva AnnaShaleva deleted the incremental-dump-creation branch July 6, 2023 11:15
@AnnaShaleva AnnaShaleva modified the milestones: v0.102.0, v0.101.4 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants