Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartcontract: allow to pass nil as parameter to (*Invoker).Call #3067

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

AnnaShaleva
Copy link
Member

Problem

Error on passing nil as an argument to (*Invoker).Call

Solution

Merge.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva AnnaShaleva added bug Something isn't working smartcontract Smart contracts and associated package labels Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #3067 (c926d53) into master (35ebdc1) will increase coverage by 0.04%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##           master    #3067      +/-   ##
==========================================
+ Coverage   84.64%   84.68%   +0.04%     
==========================================
  Files         329      329              
  Lines       43792    43827      +35     
==========================================
+ Hits        37069    37117      +48     
+ Misses       5220     5200      -20     
- Partials     1503     1510       +7     
Impacted Files Coverage Δ
pkg/neorpc/types.go 81.25% <66.66%> (-11.25%) ⬇️
pkg/core/transaction/witness_scope.go 91.04% <100.00%> (+6.56%) ⬆️
pkg/smartcontract/parameter.go 92.94% <100.00%> (+0.04%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roman-khimov roman-khimov added this to the v0.102.0 milestone Jul 21, 2023
@roman-khimov roman-khimov merged commit 7a7d0a0 into master Jul 21, 2023
13 of 18 checks passed
@roman-khimov roman-khimov deleted the allow-nil-arg branch July 21, 2023 11:51
@AnnaShaleva AnnaShaleva modified the milestones: v0.102.0, v0.101.4 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smartcontract Smart contracts and associated package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants